[PATCH 2/6] wined3d: Use snprintf() in init_debug_buffer() (Coverity).
Józef Kucia
jkucia at codeweavers.com
Wed Aug 15 04:09:48 CDT 2018
Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
---
This doesn't fix anything
---
dlls/wined3d/utils.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dlls/wined3d/utils.c b/dlls/wined3d/utils.c
index 491d888ad4c1..76f86334886b 100644
--- a/dlls/wined3d/utils.c
+++ b/dlls/wined3d/utils.c
@@ -4340,9 +4340,9 @@ struct debug_buffer
static void init_debug_buffer(struct debug_buffer *buffer, const char *default_string)
{
- strcpy(buffer->str, default_string);
+ snprintf(buffer->str, sizeof(buffer->str), default_string);
buffer->ptr = buffer->str;
- buffer->size = ARRAY_SIZE(buffer->str);
+ buffer->size = sizeof(buffer->str);
}
static void debug_append(struct debug_buffer *buffer, const char *str, const char *separator)
@@ -4355,7 +4355,7 @@ static void debug_append(struct debug_buffer *buffer, const char *str, const cha
if (size == -1 || size >= buffer->size)
{
buffer->size = 0;
- strcpy(&buffer->str[ARRAY_SIZE(buffer->str) - 4], "...");
+ strcpy(&buffer->str[sizeof(buffer->str) - 4], "...");
return;
}
--
2.16.4
More information about the wine-devel
mailing list