[PATCH 3/6] wined3d: Use snprintf() in shader_arb_request_a0() (Coverity).

Józef Kucia jkucia at codeweavers.com
Wed Aug 15 04:09:49 CDT 2018


Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
---
 dlls/wined3d/arb_program_shader.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/dlls/wined3d/arb_program_shader.c b/dlls/wined3d/arb_program_shader.c
index c05dca0046a2..97584b6124b3 100644
--- a/dlls/wined3d/arb_program_shader.c
+++ b/dlls/wined3d/arb_program_shader.c
@@ -987,9 +987,10 @@ static void shader_arb_request_a0(const struct wined3d_shader_instruction *ins,
     struct shader_arb_ctx_priv *priv = ins->ctx->backend_data;
     struct wined3d_string_buffer *buffer = ins->ctx->buffer;
 
-    if (!strcmp(priv->addr_reg, src)) return;
+    if (!strcmp(priv->addr_reg, src))
+        return;
 
-    strcpy(priv->addr_reg, src);
+    snprintf(priv->addr_reg, sizeof(priv->addr_reg), src);
     shader_addline(buffer, "ARL A0.x, %s;\n", src);
 }
 
-- 
2.16.4




More information about the wine-devel mailing list