[PATCH v2 2/5] ntdll: When creating heap, don't delete the critical section debug info

Fabian Maurer dark.shadow4 at web.de
Wed Aug 15 13:31:00 CDT 2018


In RtlDestroyHeap critSection.DebugInfo->Spare[0]
is always set to NULL,
this will crash if we deleted the debug info already

Signed-off-by: Fabian Maurer <dark.shadow4 at web.de>
---
 dlls/ntdll/heap.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/dlls/ntdll/heap.c b/dlls/ntdll/heap.c
index 44d49bca99..9eed7e6baa 100644
--- a/dlls/ntdll/heap.c
+++ b/dlls/ntdll/heap.c
@@ -977,8 +977,6 @@ static SUBHEAP *HEAP_CreateSubHeap( HEAP *heap, LPVOID address, DWORD flags,
             NtDuplicateObject( NtCurrentProcess(), sem, NtCurrentProcess(), &sem, 0, 0,
                                DUP_HANDLE_MAKE_GLOBAL | DUP_HANDLE_SAME_ACCESS | DUP_HANDLE_CLOSE_SOURCE );
             heap->critSection.LockSemaphore = sem;
-            RtlFreeHeap( processHeap, 0, heap->critSection.DebugInfo );
-            heap->critSection.DebugInfo = NULL;
         }
     }
 
-- 
2.18.0




More information about the wine-devel mailing list