[PATCH v2 2/5] ntdll: When creating heap, don't delete the critical section debug info

[Alexandre Julliard]

Fabian Maurer <dark.shadow4 at web.de> writes:

> On Donnerstag, 16. August 2018 10:25:23 CEST Alexandre Julliard wrote:
>
>> Fabian Maurer <dark.shadow4 at web.de> writes:
>
>> > Also see bug https://bugs.winehq.org/show_bug.cgi?id=45647,
>
>> > 
>
>> > chromium does in fact delete this shared csrss heap, and on win10 that
>
>> > works just fine. So I assume it should be possible on WINE too, no?
>
>> We could implement deleting a shared heap, but since we don't have a
>
>> csrss heap I'm not sure I see the point. To make chromium happy,
>
>> creating a fake non-shared heap should be sufficient.
>
> Ah, so the problem is only the shared part! If it's like that, then a non shared heap would be the solution.
>
> Another issue:
>
> Chromium assumes the structure behind the HANDLE it gets, casting it to HEAP*.
>
> Now, wine heap doesn't have the same structure as Win10 heap, so that
> doesn't work. I implemented a fake Win10 heap to return on
> GetProcessHeaps, however, I somewhat doubt this is acceptable for
> wine. How would you advise to address this issue?

You can adapt the existing structure, if tests demonstrate that this is
reasonably constant across versions.

-- 
Alexandre Julliard
julliard at winehq.org