[PATCH] msi: Unlock msi_custom_action_c on the error paths

Michael Stefaniuc mstefani at winehq.org
Thu Aug 16 15:31:22 CDT 2018


Wine-Bugs: https://bugs.winehq.org/show_bug.cgi?id=45483
Signed-off-by: Michael Stefaniuc <mstefani at winehq.org>
---
This lets the DX8 SDK finally install for me.


 dlls/msi/custom.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/dlls/msi/custom.c b/dlls/msi/custom.c
index 950681e76c..cd37a56d93 100644
--- a/dlls/msi/custom.c
+++ b/dlls/msi/custom.c
@@ -678,11 +678,13 @@ static DWORD WINAPI custom_client_thread(void *arg)
         size != sizeof(info->guid))
     {
         ERR("Failed to write to custom action client pipe: %u\n", GetLastError());
+        LeaveCriticalSection(&msi_custom_action_cs);
         return GetLastError();
     }
     if (!ReadFile(pipe, &thread64, sizeof(thread64), &size, NULL) || size != sizeof(thread64))
     {
         ERR("Failed to read from custom action client pipe: %u\n", GetLastError());
+        LeaveCriticalSection(&msi_custom_action_cs);
         return GetLastError();
     }
 
-- 
2.14.4




More information about the wine-devel mailing list