[PATCH] winecfg: Update changed state on associations checkbox click.

Nikolay Sivov bunglehead at gmail.com
Thu Aug 16 23:45:47 CDT 2018

On 8/17/2018 7:35 AM, Dmitry Timoshkov wrote:
> Nikolay Sivov <bunglehead at gmail.com> wrote:
>>>>                          case IDC_ENABLE_FILE_ASSOCIATIONS:
>>>>                              update_mime_types(hDlg);
>>>> +                            SendMessageW(GetParent(hDlg), PSM_CHANGED, 0, 0);
>>>>                              break;
>>> There is no need for that, update_mime_types() already takes care about
>>> the change. There are other handlers that don't send PSM_CHANGED too.
>> Takes care about what?
> About the change.
>> It's still possible to cancel the change.
> No, the things like check boxes don't need the cancelling.

Have you actually tried? set_reg_key() does not write to registry.

>> For consistency all of them should send that.
> I tend to disagree, and since there are other switches that behave same
> way as my patch does there are others who also do. Anyway if you don't
> like this you may want to start with actually adding support for cancelling
> the change, in current state your patch is useless.

Cancelling is already supported.

More information about the wine-devel mailing list