[PATCH] testbot: Avoid map when when items must be handled in order.
Francois Gouget
fgouget at codeweavers.com
Mon Aug 20 02:05:22 CDT 2018
Instead use 'statement($_) for (@List)' which is just as readable.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
Resending this series since they got lost due to email problems in the
last attempt.
testbot/lib/WineTestBot/PendingPatchSets.pm | 2 +-
testbot/web/Munin.pl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/testbot/lib/WineTestBot/PendingPatchSets.pm b/testbot/lib/WineTestBot/PendingPatchSets.pm
index fc22a8687..4ef7a663a 100644
--- a/testbot/lib/WineTestBot/PendingPatchSets.pm
+++ b/testbot/lib/WineTestBot/PendingPatchSets.pm
@@ -113,7 +113,7 @@ sub SubmitSubset($$$)
if (defined $Part and
open(my $PartFile, "<" , "$DataDir/patches/" . $Part->Patch->Id))
{
- map { print $CombinedFile $_; } <$PartFile>;
+ print $CombinedFile $_ for (<$PartFile>);
close($PartFile);
}
}
diff --git a/testbot/web/Munin.pl b/testbot/web/Munin.pl
index 91155b776..840d912f1 100755
--- a/testbot/web/Munin.pl
+++ b/testbot/web/Munin.pl
@@ -474,7 +474,7 @@ sub GetOutput($)
# Then print the corresponding data
print "===== data =====\n";
- map { print $_ } @Data;
+ print $_ for (@Data);
}
--
2.18.0
More information about the wine-devel
mailing list