[PATCH] user32: Create a mask from alpha channel when loading a 32 bpp icon. (v3)

Dmitry Timoshkov dmitry at baikal.ru
Tue Aug 21 06:52:32 CDT 2018


Alexandre Julliard <julliard at winehq.org> wrote:

> >> I expect it would also cause less code
> >> duplication to directly create a 1-bpp bitmap.
> >
> > What kind of code duplication do you have in mind?
> 
> The duplicate setting of biBitCount and the StretchDIBits call. If you
> generate a 1-bpp mask you can get rid of all that and simply fall
> through to the normal code path.

With the setting of biBitCount and the StretchDIBits call it's still going
to be considerably less code than the 1-bpp mask generarion from the 32-bpp
RGBA bitmap.

-- 
Dmitry.



More information about the wine-devel mailing list