[PATCH] quartz: Return correct error in IBasicAudio put_Volume

Zebediah Figura z.figura12 at gmail.com
Tue Aug 21 08:52:24 CDT 2018


On 21/08/18 01:06, Alistair Leslie-Hughes wrote:
> diff --git a/dlls/quartz/tests/filtergraph.c b/dlls/quartz/tests/filtergraph.c
> index 85079d9..3842491 100644
> --- a/dlls/quartz/tests/filtergraph.c
> +++ b/dlls/quartz/tests/filtergraph.c
> @@ -284,6 +284,20 @@ static void test_basic_video(IFilterGraph2 *graph)
>      IBasicVideo_Release(pbv);
>  }
>  
> +static void test_basic_audio(IFilterGraph2 *graph)
> +{
> +    IBasicAudio* basic;
> +    HRESULT hr;
> +
> +    hr = IFilterGraph2_QueryInterface(graph, &IID_IBasicAudio, (void **)&basic);
> +    ok(hr==S_OK, "Cannot get IBasicAudio interface returned: %x\n", hr);
> +
> +    hr = IBasicAudio_put_Volume(basic, 0);
> +    ok(hr==E_NOTIMPL || hr==S_OK, "returned: %x\n", hr);
> +
> +    IBasicAudio_Release(basic);
> +}
> +
>  static void test_media_seeking(IFilterGraph2 *graph)
>  {
>      IMediaSeeking *seeking;
> @@ -492,6 +506,7 @@ todo_wine
>  
>  static void rungraph(IFilterGraph2 *graph)
>  {
> +    test_basic_audio(graph);
>      test_basic_video(graph);
>      test_media_seeking(graph);
>      test_state_change(graph);
> 

This change looks correct, but I don't think this test is very
convincing. I think we should test put_Volume() before and after adding
a filter that supports it.



More information about the wine-devel mailing list