[PATCH] testbot/web: Fix some HTML closing tags.
Francois Gouget
fgouget at codeweavers.com
Wed Aug 22 03:56:27 CDT 2018
Also call the parent GenerateFooter() method in the Activity page so
the HTML page is terminated correctly.
Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
testbot/web/Activity.pl | 6 ++++--
testbot/web/Stats.pl | 1 +
testbot/web/Submit.pl | 3 ++-
3 files changed, 7 insertions(+), 3 deletions(-)
diff --git a/testbot/web/Activity.pl b/testbot/web/Activity.pl
index 512401751..fa842d9f4 100644
--- a/testbot/web/Activity.pl
+++ b/testbot/web/Activity.pl
@@ -94,7 +94,7 @@ sub GenerateBody($)
# Generate a custom form to let the user specify the Hours field.
$self->GenerateFormStart();
- print "<div class='ItemProperty'><label>Analyze the activity of the past <div class='ItemValue'><input type='text' name='Hours' maxlength='3' size='3' value='$self->{hours}'/></div> hours.</div>\n";
+ print "<div class='ItemProperty'><label>Analyze the activity of the past <div class='ItemValue'><input type='text' name='Hours' maxlength='3' size='3' value='$self->{hours}'/></div> hours.</label></div>\n";
$self->GenerateFormEnd();
print "<h1>${ProjectName} Test Bot activity</h1>\n";
@@ -267,6 +267,7 @@ EOF
### Generate the table footer
print "</tbody></table></div>\n";
+ print "</div>\n";
}
sub GenerateFooter($)
@@ -294,8 +295,9 @@ sub GenerateFooter($)
print "<span class='Record-deleted'>deletion</span>.</p>\n";
print "</td></tr></tbody>\n";
- print "</tbody></table></div>\n";
+ print "</table></div>\n";
print "<p class='GeneralFooterText'>Generated in ", Elapsed($self->{start}), " s</p>\n";
+ $self->SUPER::GenerateFooter();
}
diff --git a/testbot/web/Stats.pl b/testbot/web/Stats.pl
index 64f29bdcd..ccabb321a 100644
--- a/testbot/web/Stats.pl
+++ b/testbot/web/Stats.pl
@@ -335,6 +335,7 @@ sub GenerateBody($)
print "</tbody></table></div>\n";
print "<p class='GeneralFooterText'>Generated in ", Elapsed($self->{start}), " s</p>\n";
+ print "</div>\n";
}
diff --git a/testbot/web/Submit.pl b/testbot/web/Submit.pl
index 926fcb7ea..440bd8e5b 100644
--- a/testbot/web/Submit.pl
+++ b/testbot/web/Submit.pl
@@ -237,7 +237,7 @@ sub GenerateFields($)
print "<thead><tr><th class='Record'></th>\n";
print "<th class='Record'>VM Name</th>\n";
print "<th class='Record'>Description</th>\n";
- print "</th><tbody>\n";
+ print "</thead><tbody>\n";
my $VMs = CreateVMs();
if ($self->{FileType} eq "exe64")
@@ -296,6 +296,7 @@ sub GenerateFields($)
print "</tr>\n";
}
print "</tbody></table>\n";
+ print "</div><!--CollectionBlock-->\n";
}
else
{
--
2.18.0
More information about the wine-devel
mailing list