[PATCH 4/5] wined3d: Add shadow sampler capability bit to d3d_info.

Henri Verbeet hverbeet at gmail.com
Thu Aug 23 12:41:53 CDT 2018


On 23 August 2018 at 17:04, Józef Kucia <jkucia at codeweavers.com> wrote:
> Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
> ---
>  dlls/wined3d/adapter_gl.c      | 1 +
>  dlls/wined3d/directx.c         | 2 +-
>  dlls/wined3d/wined3d_private.h | 6 +++++-
>  3 files changed, 7 insertions(+), 2 deletions(-)
>
I'm not necessarily against this, but strictly speaking the
"shadow_sampler" field is somewhat superfluous. I think we simply
shouldn't be setting the WINED3DFMT_FLAG_TEXTURE flag if ARB_shadow
isn't supported, in which case wined3d_check_device_format() could
lose the special case.



More information about the wine-devel mailing list