[PATCH] user32: When registering redirected class use correct base class name

Nikolay Sivov nsivov at codeweavers.com
Thu Aug 23 15:23:19 CDT 2018


On 08/23/2018 10:59 PM, Nikolay Sivov wrote:

>
>
> On 08/23/2018 10:36 PM, Fabian Maurer wrote:
>> Some applications are dependent on the correct spelling of
>> "ComboBox", it can't be the "Combobox" from the comctl32
>> manifest.
>> We have to take it from the base class instead
>> of the versioned class name.
>>
>> Supersedes 150043
>>
>> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45689
>> Signed-off-by: Fabian Maurer <dark.shadow4 at web.de>
>> ---
>>   dlls/comctl32/tests/combo.c    | 15 +++++++++++++
>>   dlls/user32/class.c            | 41 ++++++++++++++++------------------
>>   dlls/user32/user_private.h     |  3 +--
>>   dlls/user32/win.c              |  2 +-
>>   include/wine/server_protocol.h |  9 ++++----
>>   server/class.c                 | 14 +++++++-----
>>   server/protocol.def            |  6 +++--
>>   server/request.h               |  3 ++-
>>   server/trace.c                 |  6 +++--
>>   9 files changed, 59 insertions(+), 40 deletions(-)
>
> That looks too complicated, I don't see why server changes are 
> necessary. It should be enough to fix up what CLASS_GetVersionedName() 
> returns.

For example like this.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: class.diff
Type: text/x-patch
Size: 1970 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180823/0ef582ef/attachment.bin>


More information about the wine-devel mailing list