[PATCH] urlmon/tests: Release correct uri object (Coverity).

Nikolay Sivov nsivov at codeweavers.com
Mon Dec 3 01:53:48 CST 2018


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

This is technically correct, because it releases what previous call returned, and doesn't rely on it
being same uri instance.

 dlls/urlmon/tests/uri.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/urlmon/tests/uri.c b/dlls/urlmon/tests/uri.c
index 3c5e27c8d9..64b6c56d4a 100644
--- a/dlls/urlmon/tests/uri.c
+++ b/dlls/urlmon/tests/uri.c
@@ -10528,7 +10528,7 @@ static void test_IUriBuilderFactory(void) {
                 ok(hr == S_OK, "Error: GetIUri return 0x%08x, expected 0x%08x.\n",
                     hr, S_OK);
                 ok(tmp == uri, "Error: Expected tmp to be %p, but was %p.\n", uri, tmp);
-                if(uri) IUri_Release(uri);
+                if(tmp) IUri_Release(tmp);
             }
             if(builder) IUriBuilder_Release(builder);
         }
-- 
2.19.2




More information about the wine-devel mailing list