[PATCH 2/9] windowscodecs: Add support for palette image formats to TIFF encoder.
Alexandre Julliard
julliard at winehq.org
Wed Dec 5 12:58:40 CST 2018
Dmitry Timoshkov <dmitry at baikal.ru> writes:
> @@ -752,13 +752,13 @@ static void check_tiff_format(IStream *stream, const WICPixelFormatGUID *format)
> }
> else if (IsEqualGUID(format, &GUID_WICPixelFormat2bppIndexed))
> {
> - ok(width == 32, "wrong width %u\n", width);
> + ok(width == 16, "wrong width %u\n", width);
> ok(height == 2, "wrong height %u\n", height);
>
> - ok(bps == 1, "wrong bps %d\n", bps);
> + ok(bps == 2, "wrong bps %d\n", bps);
> ok(photo == 3, "wrong photometric %d\n", photo);
> ok(samples == 1, "wrong samples %d\n", samples);
> - ok(colormap == 6, "wrong colormap %d\n", colormap);
> + ok(colormap == 12, "wrong colormap %d\n", colormap);
If the test succeeds both before and after this change, doesn't it mean
that 2bpp is never actually tested? What's the point of this test?
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list