[PATCH 2/2] comctl32: Don't ignore page creation error for a non-modal propery sheet.

Alexandre Julliard julliard at winehq.org
Tue Dec 18 13:22:02 CST 2018


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Alexandre Julliard <julliard at winehq.org> wrote:
>
>> > Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
>> > ---
>> >  dlls/comctl32/propsheet.c       | 12 ++++++++----
>> >  dlls/comctl32/tests/propsheet.c |  4 ----
>> >  2 files changed, 8 insertions(+), 8 deletions(-)
>> 
>> Is there an app that needs this?
>
> Yes, I have an application that stucks in the PropertySheet because of
> an error in the app's page dialog template. Apparently the app developers
> haven't noticed that because PropertySheet simply returns 0 under Windows
> and the app uses a different code path after that.

What app is that?  I'm asking because during code freeze I'd like to
know if the potential benefit to users is worth the risk of breaking
things. So if it's an app that nobody uses, I'd rather defer it.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list