[PATCH] gdi32: Fix memory leak (Valgrind).

Huw Davies huw at codeweavers.com
Thu Dec 20 05:21:38 CST 2018


On Wed, Dec 19, 2018 at 09:35:05PM -0800, Daniel Lehman wrote:
> diff --git a/dlls/gdi32/dibdrv/bitblt.c b/dlls/gdi32/dibdrv/bitblt.c
> index 0acb23f2e3..a84be8236e 100644
> --- a/dlls/gdi32/dibdrv/bitblt.c
> +++ b/dlls/gdi32/dibdrv/bitblt.c
> @@ -1035,6 +1035,7 @@ DWORD dibdrv_PutImage( PHYSDEV dev, HRGN clip, BITMAPINFO *info,
>                                 &dc->brush_org, rop );
>          free_clipped_rects( &clipped_rects );
>      }
> +    free_dib_info( &src_dib );
>      if (tmp_rgn) DeleteObject( tmp_rgn );
>      return ret;
>  

Thanks, this is probably fine for now.  I'll probably come back after
4.0 and rework execute_rop() so that the freeing takes place in there.

Signed-off-by: Huw Davies <huw at codeweavers.com>



More information about the wine-devel mailing list