[RFC PATCH 5/9] wined3d: Support adapter LUID via SetupAPI.

[Henri Verbeet]

On Thu, 20 Dec 2018 at 01:33, Józef Kucia <joseph.kucia at gmail.com> wrote:
> On Tue, Dec 18, 2018 at 5:21 PM Zhiyi Zhang <zzhang at codeweavers.com> wrote:
> >
> > Signed-off-by: Zhiyi Zhang <zzhang at codeweavers.com>
> > ---
> >  dlls/dxgi/tests/dxgi.c         |  4 +--
> >  dlls/wined3d/Makefile.in       |  2 +-
> >  dlls/wined3d/directx.c         | 66 +++++++++++++++++++++++++++-------
> >  dlls/wined3d/wined3d_main.c    |  2 +-
> >  dlls/wined3d/wined3d_private.h |  2 +-
> >  5 files changed, 58 insertions(+), 18 deletions(-)
>
> In my opinion, we shouldn't use SetupAPI directly in wined3d. Wined3d
> should get LUIDs from OpenGL. Device UUIDs, driver UUIDs and LUIDs are
> also exposed by OpenGL, see EXT_external_objects and
> EXT_external_objects_win32. If it's problematic to implement those
> extensions, we could also consider extending WGL_WINE_query_renderer.
>
Well, maybe. There also exist Win32 builds of wined3d though, and
setupapi would have the advantage of working there as well, while we
wouldn't necessarily be able to rely on any particular OpenGL
extension being available. Note that I haven't really looked at the
patch, but one concern I'd have would be making sure we only enumerate
adapters that are available to the current session/seat.