[PATCH 8/9] quartz/vmr9: Use assignment instead of CopyRect

Gabriel Ivăncescu gabrielopcode at gmail.com
Sat Dec 29 05:24:29 CST 2018


On 12/28/18 23:20, Michael Stefaniuc wrote:
> I'm assuming those methods will do argument validation with proper error
> code should the RECTs be NULL. Needs tests of course. But that's the
> reason I didn't replace those when I did my CopyRect() removals back in
> the day.
>
> Also we are in change freeze and pure janitorial work is kinda forbidden
> during that; especially in the later rc versions.
>
> bye
> 	michael
>

Sorry, I had assumed that it's mostly janitorial work that is acceptable 
during code freeze, that's why I sent them, my bad :-)

To be honest, I agree with Nikolay's point about most of these remaining 
CopyRect (except those not requiring NULL checks, like the combobox 
CopyRect removal).

But in such case, they should have inline helpers to be consistent with 
the others. Hopefully it's reconsidered after code freeze (the original 
inline patch), though I will split it into PtInRect and CopyRect 
separately, at least for consistency.



More information about the wine-devel mailing list