Fwd: [PATCH] systray: Hide systray for fullscreen games

[Hamish Claxton]

Hi Fabian,

The patch I sent in actually fixes the issue, I would not send in an
untested patch.

I have just done some more digging, and you are right yes.
If it wasn't working, then the systray would be showing, as 0x1 is less
than whatever resolution you are using.

Just about to submit a v2 patch, which solves this and is actually smaller
by just calling GetSystemMetrics with SM_CXSCREEN, SM_CYSCREEN,
SM_CXFULLSCREEN & SM_CYFULLSCREEN.

Thanks in Advance,
Hamish

On Sun, Dec 30, 2018 at 8:51 AM Fabian Maurer <dark.shadow4 at web.de> wrote:

> Hi Hamish,
>
>
>
> SM_CXSCREEN and SM_CYSCREEN are constants, defined as 0 respective 1.
>
>
>
> So basically your code is
>
>
>
> > if ( !( window.right >= 0 && window.bottom >= 1 ) )
>
> > do_show_systray();
>
>
>
> And this is not correct. Those values are just flags to use in the
> GetSystemMetrics function.
>
> Did you check that the patch you sent in actually fixes the issue? Or did
> you only test with a previous version of your patch? Because I don't see
> how this would help.
>
>
>
> Regards,
>
> Fabian Maurer
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20181230/7317153b/attachment.html>