[PATCH] testbot/web: Add the job's remarks as a tooltip on the activity page.

Francois Gouget fgouget at codeweavers.com
Mon Feb 5 20:12:10 CST 2018


This allows getting a quick sense of what the task is about without
having to change page or bloating the content of the table.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/web/Activity.pl | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/testbot/web/Activity.pl b/testbot/web/Activity.pl
index 6ca3199a..13c77c68 100644
--- a/testbot/web/Activity.pl
+++ b/testbot/web/Activity.pl
@@ -228,7 +228,9 @@ EOF
             $Label .= "/64" if ($Bitness);
           }
         }
-        $Label = "<a href='/JobDetails.pl?Key=". $VMStatus->{job}->Id ."#k". ($VMStatus->{step}->No * 100 + $VMStatus->{task}->No) ."'>$Label</a>";
+        my $Key = $VMStatus->{job}->Id ."#k". ($VMStatus->{step}->No * 100 + $VMStatus->{task}->No);
+        my $Title = $self->escapeHTML($VMStatus->{job}->Remarks);
+        $Label = "<a href='/JobDetails.pl?Key=$Key' title='$Title'>$Label</a>";
       }
       elsif ($VMStatus->{status} eq "dirty")
       {
-- 
2.15.1



More information about the wine-devel mailing list