[PATCH 4/5] kerberos: Allocate a buffer for the package info structure in kerberos_SpQueryContextAttributes.

[Dmitry Timoshkov]

Hans Leidekker <hans at codeweavers.com> wrote:

> > I'd assume same thing as MSDN states in the SpGetInfo() notes: the provider is
> > free to return pointers to dynamic and constant data in the returned buffer,
> > and it's responsibility of LSA to copy data to a flat buffer before returning
> > it to a client. Same comment applies to a similar patch for the NTLM provider.
> 
> This buffer can currently be retrieved directly from NTLM, without
> involving LSA. This way we can free the buffer unconditionally in the
> negotiate tests. Things would change if NTLM was moved behing the LSA
> interface too, but in that case it's still not wrong to do it here, as
> long as the LSA wrapper and the provider agree.

In that case a buffer allocated by the provider will be leaked since
LSA will do nothing with it.

-- 
Dmitry.