[PATCH 1/4] include: Introduce todo_wine32 and todo_wine64 macros

[Zebediah Figura]

On 12/02/18 04:29, Alexandre Julliard wrote:
> Alex Henrie <alexhenrie24 at gmail.com> writes:
> 
>> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
>> ---
>>  include/wine/test.h | 8 ++++++++
>>  1 file changed, 8 insertions(+)
>>
>> diff --git a/include/wine/test.h b/include/wine/test.h
>> index 4ec66d5391..3d47bfbce2 100644
>> --- a/include/wine/test.h
>> +++ b/include/wine/test.h
>> @@ -126,6 +126,14 @@ extern void __winetest_cdecl winetest_trace( const char *msg, ... ) WINETEST_PRI
>>  #define todo_wine               todo_if(!strcmp(winetest_platform, "wine"))
>>  #define todo_wine_if(is_todo)   todo_if((is_todo) && !strcmp(winetest_platform, "wine"))
>>  
>> +#ifdef _WIN64
>> +#define todo_wine32
>> +#define todo_wine64 todo_wine
>> +#else
>> +#define todo_wine32 todo_wine
>> +#define todo_wine64
>> +#endif
> 
> That doesn't look like something that would be used enough to justify
> new global macros, especially now that we have todo_wine_if() that can
> be used for this.
> 

Why not just do

#ifndef __i386__
    todo_wine
#endif

inside each relevant test? Especially since the marshalling tests will
fail also on ARM.