[PATCH 1/5] winegstreamer: Stop creating the filter if gstreamer fails to render.
Andrew Eikum
aeikum at codeweavers.com
Thu Feb 22 08:18:22 CST 2018
On Tue, Feb 20, 2018 at 08:12:58PM -0600, Zebediah Figura wrote:
> diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
> index a19c64f..ea61ed5 100644
> --- a/dlls/winegstreamer/gstdemux.c
> +++ b/dlls/winegstreamer/gstdemux.c
> @@ -1165,7 +1164,7 @@ static HRESULT GST_Connect(GSTInPin *pPin, IPin *pConnectPin, ALLOCATOR_PROPERTI
>
> if (!This->cStreams) {
> FIXME("GStreamer could not find any streams\n");
> - hr = E_FAIL;
> + return E_FAIL;
> } else {
> gst_pad_query_duration(This->ppPins[0]->their_src, GST_FORMAT_TIME, &duration);
> for (i = 0; i < This->cStreams; ++i) {
Would you mind removing the now-redundant else here? All of the other
patches look good to me.
Thanks,
Andrew
More information about the wine-devel
mailing list