[PATCH] crypt32/tests: Add CryptBinaryToStringW test

Nikolay Sivov bunglehead at gmail.com
Thu Feb 22 23:41:44 CST 2018


On 2/23/2018 6:36 AM, Alistair Leslie-Hughes wrote:
>  
> +static void testBinaryToStringW(void)
> +{
> +    BYTE *data;
> +    int size = 16656;

Why this size? Is it reproducible with smaller buffer?

> +    DWORD out = 0;
> +    BOOL ret;
> +
> +    if (!pCryptBinaryToStringW)
> +    {
> +        win_skip("CryptBinaryToStringW is not available\n");
> +        return;
> +    }

You don't need that, it's available on all testbot VMs.

> +
> +    data = heap_alloc_zero(size);
> +    ret = pCryptBinaryToStringW(data, size, CRYPT_STRING_BASE64, NULL, &out);
> +    ok(ret, "CryptBinaryToStringW failed: %d\n", GetLastError());
> +    todo_wine ok(out == 22903, "return size returned: %d\n", out);
> +
> +    heap_free(data);

I think this should test actual output, matching length alone is not enough.



More information about the wine-devel mailing list