[PATCH v2 02/10] winevulkan: Add stub ICD.

[Józef Kucia]

On Fri, Feb 23, 2018 at 8:22 AM, Roderick Colenbrander
<thunderbird2k at gmail.com> wrote:
> diff --git a/dlls/winevulkan/vulkan.c b/dlls/winevulkan/vulkan.c
> new file mode 100644
> index 0000000000..ab9c52ee60
> --- /dev/null
> +++ b/dlls/winevulkan/vulkan.c
> @@ -0,0 +1,54 @@
> +/* Wine Vulkan ICD implementation
> + *
> + * Copyright 2017 Roderick Colenbrander
> + *
> + * This library is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU Lesser General Public
> + * License as published by the Free Software Foundation; either
> + * version 2.1 of the License, or (at your option) any later version.
> + *
> + * This library is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> + * Lesser General Public License for more details.
> + *
> + * You should have received a copy of the GNU Lesser General Public
> + * License along with this library; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA
> + */
> +
> +#include <stdarg.h>
> +
> +#include "windef.h"
> +#include "winbase.h"
> +
> +#include "wine/debug.h"
> +#include "wine/vulkan.h"
> +
> +WINE_DEFAULT_DEBUG_CHANNEL(vulkan);
> +
> +void * WINAPI wine_vk_icdGetInstanceProcAddr(VkInstance instance, const char *name)
> +{
> +    FIXME("stub: %p %s\n", instance, debugstr_a(name));
> +    return NULL;
> +}
> +
> +VkResult WINAPI wine_vk_icdNegotiateLoaderICDInterfaceVersion(uint32_t *supported_version)
> +{
> +    FIXME("stub: %p\n", pSupportedVersion);

The function is now named "supported_version":

../../../wine-git/dlls/winevulkan/vulkan.c: In function
wine_vk_icdNegotiateLoaderICDInterfaceVersion:
../../../wine-git/dlls/winevulkan/vulkan.c:38:264: error:
pSupportedVersion undeclared (first use in this function)
     FIXME("stub: %p\n", pSupportedVersion);

> +    return VK_ERROR_INCOMPATIBLE_DRIVER;
> +}
> +
> +BOOL WINAPI DllMain(HINSTANCE hinst, DWORD reason, LPVOID reserved)

It's not important but "void *reserved" would be preferred.

> +{
> +    switch(reason)

Please put a space before the switch keyword.

> +    {
> +        case DLL_PROCESS_ATTACH:
> +            DisableThreadLibraryCalls(hinst);
> +            break;
> +
> +        case DLL_THREAD_ATTACH:
> +            break;
> +    }
> +    return TRUE;
> +}
> diff --git a/dlls/winevulkan/winevulkan.spec b/dlls/winevulkan/winevulkan.spec
> new file mode 100644
> index 0000000000..c3bccc11f2
> --- /dev/null
> +++ b/dlls/winevulkan/winevulkan.spec
> @@ -0,0 +1,2 @@
> +@ stdcall vk_icdGetInstanceProcAddr(str ptr) wine_vk_icdGetInstanceProcAddr

The spec entry looks wrong to me. It should be
vk_icdGetInstanceProcAddr(ptr str).

> +@ stdcall vk_icdNegotiateLoaderICDInterfaceVersion(ptr) wine_vk_icdNegotiateLoaderICDInterfaceVersion
> --
> 2.14.3
>
>
>