[PATCH] w2_32: Ignore setting several port assignment related socket options.

[Zebediah Figura]

On 26/02/18 02:04, Michael Müller wrote:
> Am 26.02.2018 um 04:47 schrieb Zebediah Figura:
>> I can't seem to find any reported application that depends on these
>> values returning success, and, in lieu of one, I'm not sure that this
>> patch has any value.
>>
>> Michael, without meaning to drag you back into a project that you've
>> resigned from, could you please offer some explanation as to what this
>> patch was meant for?
>>
> 
> The patch is for Overwatch. You can, for example, see Overwatch calling
> it in the following debug logs:
> 
> https://bugs.winehq.org/attachment.cgi?id=59293
> https://bugs.winehq.org/attachment.cgi?id=59134
> 

Thanks; no objections from me then.

> As far as I remember the application checked for an error and failed
> otherwise.
> 
> Just to make it shorter in the future: Except some speed improvement
> experiments that we did, all the patches in Wine Staging fix an
> application or bring it further. The patches just do not always come
> with a list of fixed applications attached, just like the ones sent to
> wine-devel.
> 

Sure, and I don't doubt that. It would on the other hand be good to know
what specifically they fix, given that e.g. [1] is meant to fix a broken
application that was later fixed upstream.

[1]
https://github.com/wine-staging/wine-staging/tree/master/patches/ntdll-call_thread_func_wrapper