[PATCH] comctl32/progress: Fix wrapping of values in PBM_STEPIT and add tests

Fabian Maurer dark.shadow4 at web.de
Mon Feb 26 17:16:25 CST 2018


On Montag, 26. Februar 2018 23:21:07 CET Nikolay Sivov wrote:
> On 2/27/2018 12:14 AM, Fabian Maurer wrote:
> > +
> > +    SendMessageA(progress, PBM_SETSTEP, TEST_STEP_SMALL, 0);
> > +    SendMessageA(progress, PBM_STEPIT, 0, 0);
> 
> Maybe have this as SETPOS instead?
> 
> > +    for (i = 1; i < 15; i++)
> > +    {
> > +        pos_actual = SendMessageA(progress, PBM_STEPIT, 0, 0);
> 
> That's previous position, not actual/current.

I thought it's easier to work with that way, I've changed it in the rewrite of the patch.

Regards,
Fabian Maurer

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180227/1123e8e0/attachment.html>


More information about the wine-devel mailing list