[PATCH] msxml3: Don't set properties directly

Marcus Meissner meissner at suse.de
Wed Feb 28 06:23:30 CST 2018


On Tue, Feb 27, 2018 at 03:52:43PM -0600, Zebediah Figura wrote:
> On 27/02/18 13:07, Nikolay Sivov wrote:
> > This might as well be correct, but I'll have to see myself.
> > 
> > Valgrind results are reproducible, but test doesn't always crash, is
> > that right?
> > 
> > 
> 
> It's not correct—as the tests show (specifically
> test_get_ownerDocument), the properties should be shared. What probably
> should be done instead is to refcount the properties, or move them to a
> common structure. I looked into this at one point but wasn't sure enough
> as to the architecture to try to fix it.

I tried to fix this problem too, but I gave up, it probably needs a lot of 
restructuring.

Ciao, Marcus



More information about the wine-devel mailing list