[PATCH 1/2] mshtml/tests: Test document stream creation failure (Coverity)
Nikolay Sivov
nsivov at codeweavers.com
Fri Jan 5 05:38:56 CST 2018
Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---
dlls/mshtml/tests/activex.c | 7 +++++--
dlls/mshtml/tests/dom.c | 7 +++++--
2 files changed, 10 insertions(+), 4 deletions(-)
diff --git a/dlls/mshtml/tests/activex.c b/dlls/mshtml/tests/activex.c
index 78602b7146..8b6a47c391 100644
--- a/dlls/mshtml/tests/activex.c
+++ b/dlls/mshtml/tests/activex.c
@@ -2246,6 +2246,7 @@ static void doc_load_string(IHTMLDocument2 *doc, const char *str)
IStream *stream;
HGLOBAL mem;
SIZE_T len;
+ HRESULT hr;
notif_doc = doc;
@@ -2253,9 +2254,11 @@ static void doc_load_string(IHTMLDocument2 *doc, const char *str)
len = strlen(str);
mem = GlobalAlloc(0, len);
memcpy(mem, str, len);
- CreateStreamOnHGlobal(mem, TRUE, &stream);
+ hr = CreateStreamOnHGlobal(mem, TRUE, &stream);
+ ok(hr == S_OK, "Failed to create a stream, hr %#x.\n", hr);
- IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+ hr = IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+ ok(hr == S_OK, "Failed to get IPersistStreamInit, hr %#x.\n", hr);
IPersistStreamInit_Load(init, stream);
IPersistStreamInit_Release(init);
diff --git a/dlls/mshtml/tests/dom.c b/dlls/mshtml/tests/dom.c
index 6c0b637a71..b00346759f 100644
--- a/dlls/mshtml/tests/dom.c
+++ b/dlls/mshtml/tests/dom.c
@@ -10518,6 +10518,7 @@ static IHTMLDocument2 *create_doc_with_string(const char *str)
IHTMLDocument2 *doc;
HGLOBAL mem;
SIZE_T len;
+ HRESULT hr;
notif_doc = doc = create_document();
if(!doc)
@@ -10527,9 +10528,11 @@ static IHTMLDocument2 *create_doc_with_string(const char *str)
len = strlen(str);
mem = GlobalAlloc(0, len);
memcpy(mem, str, len);
- CreateStreamOnHGlobal(mem, TRUE, &stream);
+ hr = CreateStreamOnHGlobal(mem, TRUE, &stream);
+ ok(hr == S_OK, "Failed to create a stream, hr %#x.\n", hr);
- IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+ hr = IHTMLDocument2_QueryInterface(doc, &IID_IPersistStreamInit, (void**)&init);
+ ok(hr == S_OK, "Failed to get IPersistStreamInit, hr %#x.\n", hr);
IPersistStreamInit_Load(init, stream);
IPersistStreamInit_Release(init);
--
2.15.1
More information about the wine-devel
mailing list