[PATCH v2 5/6] shlwapi/tests: Add missing return value checks to istream tests (Coverity)
Alex Henrie
alexhenrie24 at gmail.com
Mon Jan 8 02:19:29 CST 2018
Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
v2: Now checking if ret is nonzero instead of using the SUCCEEDED macro
dlls/shlwapi/tests/istream.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/dlls/shlwapi/tests/istream.c b/dlls/shlwapi/tests/istream.c
index 54a73fcf5e..926f2f8157 100644
--- a/dlls/shlwapi/tests/istream.c
+++ b/dlls/shlwapi/tests/istream.c
@@ -663,8 +663,10 @@ static void test_SHCreateStreamOnFileEx_CopyTo(void)
static const WCHAR prefix[] = { 'T', 'S', 'T', 0 };
GetTempPathW(MAX_PATH, tmpPath);
- GetTempFileNameW(tmpPath, prefix, 0, srcFileName);
- GetTempFileNameW(tmpPath, prefix, 0, dstFileName);
+ ret = GetTempFileNameW(tmpPath, prefix, 0, srcFileName);
+ ok(ret != 0, "GetTempFileName failed, got error %d\n", GetLastError());
+ ret = GetTempFileNameW(tmpPath, prefix, 0, dstFileName);
+ ok(ret != 0, "GetTempFileName failed, got error %d\n", GetLastError());
ret = SHCreateStreamOnFileEx(srcFileName, STGM_CREATE | STGM_READWRITE | STGM_DELETEONRELEASE, FILE_ATTRIBUTE_TEMPORARY, FALSE, NULL, &src);
ok(SUCCEEDED(ret), "SHCreateStreamOnFileEx failed with ret=0x%08x\n", ret);
--
2.15.1
More information about the wine-devel
mailing list