[PATCH] kernel32/tests: Test CreateFileMapping with a foreign architecture dll

Alexandre Julliard julliard at winehq.org
Mon Jan 8 05:37:10 CST 2018


André Hentschel <nerv at dawncrow.de> writes:

> Am 07.01.2018 um 17:21 schrieb Dmitry Timoshkov:
>> André Hentschel <nerv at dawncrow.de> wrote:
>> 
>>> This was written with project Hangover in mind, we hoped that we can get rid of https://github.com/AndreRH/wine/commit/8935bdf941f5f2866c2fa4695eb15d94337fae9e
>>> Sadly this seems not to be the case, as Wine already behaves like modern Windows here
>> 
>> Wouldn't this kind of test be simpler adding on top of
>> 8a3624afc27953732013a90a54d71b9b66b34205?
>> 
>
> Those tests are not loop based, so not cleaning them up is simpler

You can just add a single test, I don't think testing all flag
combinations is meaningful.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list