[PATCH 1/1] wininet/test: Check null pointer in InternetGetSecurityInfoByURLW

Wei Xie xiewei at deepin.com
Tue Jan 9 02:39:30 CST 2018


Because last error not set as 0 in vista and w2008, but others do it. If set last error as 0xdeadbeef in these two tests, the test will failed
https://testbot.winehq.org/JobDetails.pl?Key=35144
 
------------------ Original ------------------
From:  "Jactry Zeng"<jactry92 at gmail.com>;
Date:  Tue, Jan 9, 2018 04:28 PM
To:  "Wei Xie"<xiewei at deepin.com>;
Cc:  "wine-devel"<wine-devel at winehq.org>;
Subject:  Re: [PATCH 1/1] wininet/test: Check null pointer in InternetGetSecurityInfoByURLW
 
Hi Wei,

Thanks for contribution!
I have a question about the tests:

+
+        SetLastError(0);
+        res = pInternetGetSecurityInfoByURLA(url, &chain, NULL);
+        ok_(__FILE__,line)(res && GetLastError() == 0,
+                           "InternetGetSecurityInfoByURLA failed returned: %x(%u), expected success\n", res, GetLastError());
+
+        SetLastError(0);
+        res = pInternetGetSecurityInfoByURLA(url, NULL, &flags);
+        ok_(__FILE__,line)(res && GetLastError() == 0,
+                           "InternetGetSecurityInfoByURLA failed returned: %x(%u), expected success\n", res, GetLastError());
     }else {

Why not set last error as 0xdeadbeef in these two tests?


2018-01-08 15:57 GMT+08:00 Wei Xie <xiewei at deepin.com>:






-- 
Regards,
Jactry Zeng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180109/ebd94759/attachment.html>


More information about the wine-devel mailing list