[PATCH] urlmon/tests: Make sure we don't run more than one thread at once.

Jacek Caban jacek at codeweavers.com
Wed Jan 10 15:36:08 CST 2018


On 10.01.2018 22:21, Zebediah Figura wrote:
> On 01/10/2018 02:50 PM, Jacek Caban wrote:
>> Hi Zebediah,
>>
>> On 09.01.2018 03:23, Zebediah Figura wrote:
>>>  
>>> +    /* make sure that the last thread terminates before we start this one */
>>> +    if (last_thread)
>>> +        ok(WaitForSingleObject(last_thread, 90000) == WAIT_OBJECT_0, "wait timed out\n");
>>> +
>>
>> We already have event_complete for similar purpose. Would setting the
>> event in thread_proc before returning in redirect_only branch and
>> waiting for it in ProtocolEmul_Continue before
>> ReportResult(INET_E_REDIRECT_FAILED) call solve the problem?
>>
>>
>> Thanks,
>>
>> Jacek
>>
> Hi, thanks for the attention.

Thanks for fixing it.

> Unfortunately that doesn't work because calling Switch() [from the
> thread] waits for Continue() [on the main thread] to complete, i.e. it
> waits for event_complete2.


It seems to me that we could simply set event_complete2 before waiting
for event_complete.


Jacek




More information about the wine-devel mailing list