[PATCH 2/2] advapi32/tests: Fully initialize ACLs (Valgrind).
Matteo Bruni
mbruni at codeweavers.com
Wed Jan 10 15:59:03 CST 2018
Signed-off-by: Matteo Bruni <mbruni at codeweavers.com>
---
I agree with Sebastian (bug 38671 comment 1) in that it seems
harmless. Let's make Valgrind happy anyway...
For bugs 38671, 43308, 43309.
dlls/advapi32/tests/security.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/dlls/advapi32/tests/security.c b/dlls/advapi32/tests/security.c
index 769328be81..d5e898ca8a 100644
--- a/dlls/advapi32/tests/security.c
+++ b/dlls/advapi32/tests/security.c
@@ -3559,7 +3559,7 @@ static void test_CreateDirectoryA(void)
sa.bInheritHandle = TRUE;
InitializeSecurityDescriptor(pSD, SECURITY_DESCRIPTOR_REVISION);
pCreateWellKnownSid(WinBuiltinAdministratorsSid, NULL, admin_sid, &sid_size);
- pDacl = HeapAlloc(GetProcessHeap(), 0, 100);
+ pDacl = HeapAlloc(GetProcessHeap(), HEAP_ZERO_MEMORY, 100);
bret = InitializeAcl(pDacl, 100, ACL_REVISION);
ok(bret, "Failed to initialize ACL.\n");
bret = pAddAccessAllowedAceEx(pDacl, ACL_REVISION, OBJECT_INHERIT_ACE|CONTAINER_INHERIT_ACE,
@@ -6306,6 +6306,7 @@ static void test_AddMandatoryAce(void)
HeapFree(GetProcessHeap(), 0, sd2);
CloseHandle(handle);
+ memset(buffer_acl, 0, sizeof(buffer_acl));
ret = InitializeAcl(acl, 256, ACL_REVISION);
ok(ret, "InitializeAcl failed with %u\n", GetLastError());
@@ -6793,6 +6794,7 @@ static void test_maximum_allowed(void)
ret = InitializeSecurityDescriptor(sd, SECURITY_DESCRIPTOR_REVISION);
ok(ret, "InitializeSecurityDescriptor failed with %u\n", GetLastError());
+ memset(buffer_acl, 0, sizeof(buffer_acl));
ret = InitializeAcl(acl, 256, ACL_REVISION);
ok(ret, "InitializeAcl failed with %u\n", GetLastError());
ret = SetSecurityDescriptorDacl(sd, TRUE, acl, FALSE);
@@ -6922,6 +6924,7 @@ static void test_token_security_descriptor(void)
ret = InitializeSecurityDescriptor(sd, SECURITY_DESCRIPTOR_REVISION);
ok(ret, "InitializeSecurityDescriptor failed with error %u\n", GetLastError());
+ memset(buffer_acl, 0, sizeof(buffer_acl));
ret = InitializeAcl(acl, 256, ACL_REVISION);
ok(ret, "InitializeAcl failed with error %u\n", GetLastError());
--
2.13.6
More information about the wine-devel
mailing list