[PATCH] wininet: Fix crash when secure_proxy_connect use a rewrite

[Wei Xie]

------------------ Original ------------------
From:  "Jacek Caban"<jacek at codeweavers.com>;
Date:  Thu, Jan 11, 2018 05:04 AM
To:  "Wei Xie"<xiewei at deepin.com>; "wine-devel"<wine-devel at winehq.org>;
Subject:  Re: [PATCH 1/1] wininet: Fix crash when connection is null inNETCON_secure_connect
 
Hi Wei,

On 05.01.2018 02:03, Wei Xie wrote:
> request->netconn may be released before call NETCON_secure_connect.
>
> 5029             if(!request->contentLength)
> 5030                 http_release_netconn(request, TRUE);
>
> 5121             if (secure_proxy_connect && request->status_code ==
> HTTP_STATUS_OK)
> 5122             {
> 5123                 res = NETCON_secure_connect(request->netconn,
> request->server);
>
> I don't know how write a test patch


The whole secure_proxy_connect could really use a rewrite, but for this
particular problem, I think that the right solution would be to not
release connection in line 5030 if secure_proxy_connect is TRUE.


Thanks,

Jacek
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-wininet-Fix-crash-when-secure_proxy_connect-use-a-re.patch
Type: application/octet-stream
Size: 1070 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180111/fa8fa2ea/attachment.obj>