[PATCH 04/13] secur32: Implement InitializeSecurityContext in the SSP/AP wrapper.

Dmitry Timoshkov dmitry at baikal.ru
Wed Jan 31 03:29:37 CST 2018


Hans Leidekker <hans at codeweavers.com> wrote:

> > +    status = lsa_package->lsa_api->InitLsaModeContext(lsa_credential, lsa_context,
> > +        target_name ? &target_name_us : NULL, context_req, target_data_rep, input,
> > +        &new_lsa_context, output, context_attr, ts_expiry, &mapped_context, NULL /* FIXME */);
> > +    if (status == SEC_E_OK)
> > +    {
> > +        new_context->dwLower = (ULONG_PTR)new_lsa_context;
> > +        new_context->dwUpper = (ULONG_PTR)lsa_package;
> > +    }
> 
> You should also accept SEC_I_CONTINUE_NEEDED here, otherwise the caller
> won't see the new context in a three-leg authentication.

Well spotted (here and in another patch), thanks for the review.

-- 
Dmitry.



More information about the wine-devel mailing list