[PATCH] gdi32: Add DECLSPEC_HOTPATCH to GetDIBits

Dmitry Timoshkov dmitry at baikal.ru
Sun Jul 1 06:46:54 CDT 2018


Stefan Dösinger <stefandoesinger at gmail.com> wrote:

> I still think adding a 2 byte (or 8 byte) NOP to every WINAPI or CDECL
> function is wasteful.

Just try to look at the problem from the other point of view: compare
effort needed to add a 2 bytes nop to the efforts of investigating every
bug out there that at least slightly smells like a hot patching issue.
On the other hand entry point stack alignment also could be treated as
a case by case thing, but in the end it was decided to add forcing stack
alignment spec to the __stdcall definition.

-- 
Dmitry.



More information about the wine-devel mailing list