[PATCH] gdi32: Add DECLSPEC_HOTPATCH to GetDIBits

[Alexandre Julliard]

Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Stefan Dösinger <stefandoesinger at gmail.com> wrote:
>
>> I still think adding a 2 byte (or 8 byte) NOP to every WINAPI or CDECL
>> function is wasteful.
>
> Just try to look at the problem from the other point of view: compare
> effort needed to add a 2 bytes nop to the efforts of investigating every
> bug out there that at least slightly smells like a hot patching issue.
> On the other hand entry point stack alignment also could be treated as
> a case by case thing, but in the end it was decided to add forcing stack
> alignment spec to the __stdcall definition.

Agreed, if there are no known cases where the hotpatch prefix breaks
something, then we might as well use it for all functions.

-- 
Alexandre Julliard
julliard at winehq.org