[PATCH] include: Always enable DECLSPEC_HOTPATCH for explicitly stdcall functions.

[Alex Henrie]

On Mon, Jul 2, 2018 at 4:47 PM Stefan Dösinger
<stefandoesinger at gmail.com> wrote:
>
> Am 02.07.2018 um 16:43 schrieb Alex Henrie <alexhenrie24 at gmail.com>:
>
> In that case, I think we want to just add
> __attribute__((__ms_hook_prologue__)) if the GCC version is >= 4.6.
>
> Does gcc's configure script still depend on movl.s support in GNU as to enable __ms_hook_prologue__ support? I wrote it this way at the time because I made gcc explicitly generate "movl.s" instructions. Those were later replaced by hardcoded byte values ("emit .byte 0x8b 0xff" or so). Thus gcc does not strictly need movl.s support any more, but I think the check in ./configure was not removed.

configure.ac still defines HAVE_AS_IX86_SWAP, but it's not used anywhere.

> Long story short, a gcc 7.3 built on OSX might not have __ms_hook_prologue__ support.

In the worst case scenario, that just means a bunch of compiler
warnings until we fix our windef.h. But if I've understood the GCC
code correctly, there's no difference in __ms_hook_prologue__ support
between Linux and OSX, so it will never be a problem.

-Alex