[PATCH] include: Always enable DECLSPEC_HOTPATCH for explicitly stdcall functions.

[Nikolay Sivov]

On 07/03/2018 11:54 AM, Zebediah Figura wrote:
> On 03/07/18 10:11, Zebediah Figura wrote:
>> On 03/07/18 00:34, Alex Henrie wrote:
>>> OK, I don't think this is going to work at all. After adding
>>> __ms_hook_prologue__ to the definition of __stdcall, I get tons of
>>> "warning: ‘ms_hook_prologue’ attribute does not apply to types".
>>>
>>> This makes me think that, at least for now, it's best to continue to
>>> add DECLSPEC_HOTPATCH on a case-by-case basis.
>>>
>>> -Alex
>>>
>>>
>> This seems like it would be a GCC bug; it works with other attributes
>> and there's no architectural reason it can't work here.
>>
>>
> I guess it's because of this:
>
> https://gcc.gnu.org/ml/gcc-patches/2009-09/msg01635.html
>
> I'm not sure what to do about this. Perhaps only set it on WINAPI rather
> than __stdcall? Will that work everywhere?

If we want that for methods too, then no, because of 
STDMETHODCALLTYPE/STDAPICALLTYPE. Also because of things like WMIAPI or 
WINGDIPAPI.