[PATCH 3/4] [programs\cmd] Fix issue in WCMD_assoc highlighted by valgrind
Jason Edmeades
us at edmeades.me.uk
Wed Jul 4 16:08:40 CDT 2018
Fixes bug#38849
In an error condition, the wrong variable was being used for an insert,
resulting in a read from uninitialized data. This could be triggered for
example by 'ftype jason=', and the error message should have included
jason but instead was just ''.
Signed-off-by: Jason Edmeades <us at edmeades.me.uk>
---
programs/cmd/builtins.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/programs/cmd/builtins.c b/programs/cmd/builtins.c
index 3a0981d222..57a41c4752 100644
--- a/programs/cmd/builtins.c
+++ b/programs/cmd/builtins.c
@@ -4923,7 +4923,7 @@ void WCMD_assoc (const WCHAR *args, BOOL assoc) {
LoadStringW(hinst, WCMD_NOFTYPE, msgbuffer,
sizeof(msgbuffer)/sizeof(WCHAR));
}
- WCMD_output_stderr(msgbuffer, keyValue);
+ WCMD_output_stderr(msgbuffer, args);
errorlevel = 2;
}
--
2.17.1
More information about the wine-devel
mailing list