[PATCH 1/3] ntdll: Only set owned bits in RTL_BITMAP

Michał Janiszewski janisozaur at gmail.com
Wed Jul 4 16:22:04 CDT 2018


It looks like your way indeed solves the problem as I am no longer able to
observe the issue I saw earlier and I simply have not fully understood the
way you rewrote the code.
Thanks for cleaning it up then.
Michał.

On 4 July 2018 at 09:41, Alexandre Julliard <julliard at winehq.org> wrote:

> Michał Janiszewski <janisozaur at gmail.com> writes:
>
> > Hi,
> > I would like to complain the commit mentioned by the bot is not the
> commit I sent out.
> > My patch guarded from access to unallocated memory, while the commit
> mentioned and attributed to me tests if there are any bits to set/clear and
> proceeds to use the memory it does not own anyway.
> > Please revert a1ed500836806ef46fc3eafa7ce5f8621938cbc1, I shall come up
> with a test for the scenario I'm talking about.
>
> I believe it does the same thing in a simpler way, but if you have a
> test demonstrating that it's still broken, please submit it and I'll fix
> the code.
>
> --
> Alexandre Julliard
> julliard at winehq.org
>



-- 
Michal Janiszewski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180704/3b067a8c/attachment.html>


More information about the wine-devel mailing list