[PATCH] winex11.drv: Fix drawing dashed lines.

Dmitry Timoshkov dmitry at baikal.ru
Thu Jul 5 01:56:21 CDT 2018


For some reason XDrawLine() and XDrawRectangle() draw only very first segment
of a dashed line if line_width is set to 0.

I couldn't find an explanation in the XLib programming guide.

In order to see the problem add "X11 Driver"/"ClientSideGraphics"="N" to
the registry, then the bug could be noticed as a missing focus regtangle
on focused buttons, missing dashed lines between nodes in regedit, etc.

Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
---
 dlls/winex11.drv/graphics.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dlls/winex11.drv/graphics.c b/dlls/winex11.drv/graphics.c
index e8c59f9baf..586e64afa1 100644
--- a/dlls/winex11.drv/graphics.c
+++ b/dlls/winex11.drv/graphics.c
@@ -449,6 +449,7 @@ static BOOL X11DRV_SetupGCForPen( X11DRV_PDEVICE *physDev )
     val.line_width = physDev->pen.width;
     if (val.line_width <= 1) {
 	val.cap_style = CapNotLast;
+        val.line_width = 1;
     } else {
 	switch (physDev->pen.endcap)
 	{
-- 
2.17.1




More information about the wine-devel mailing list