[PATCH] ntdll: Don't abort if we overflow the thread debug buffer.

Alexandre Julliard julliard at winehq.org
Thu Jul 5 07:24:57 CDT 2018


Zebediah Figura <z.figura12 at gmail.com> writes:

> On 05/07/18 13:47, Alexandre Julliard wrote:
>> Zebediah Figura <z.figura12 at gmail.com> writes:
>> 
>>> Instead, just print it as-is.
>>>
>>> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
>>> ---
>>> I encountered this abort() while trying to play a certain video with
>>> winegstreamer, which spewed far too much debug data upon failing to find an
>>> adequate decoder.
>> 
>> The abort is a feature, please fix the corresponding traces
>> instead. Usually it's because of a missing \n or debugstr_a().
>> 
>
> Fair enough, although I guess this doesn't give us an easy way to print
> data longer than 300 characters.

That's to encourage keeping individual traces to a manageable size, so
that they can be line-buffered. Arbitrarily long traces would most
likely become unreadable anyway when they get mixed up with output from
other threads.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list