[PATCH 1/4] quartz: Use CBaseFilter::FindPin().

[Zebediah Figura]

On 05/07/18 19:18, Alexandre Julliard wrote:
> Zebediah Figura <z.figura12 at gmail.com> writes:
> 
>> Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
>> ---
>>  dlls/quartz/acmwrapper.c |  2 +-
>>  dlls/quartz/avidec.c     |  2 +-
>>  dlls/quartz/avisplit.c   |  2 +-
>>  dlls/quartz/filesource.c | 23 +----------------------
>>  dlls/quartz/mpegsplit.c  |  2 +-
>>  dlls/quartz/parser.c     | 10 ----------
>>  dlls/quartz/parser.h     |  1 -
>>  dlls/quartz/waveparser.c |  2 +-
>>  8 files changed, 6 insertions(+), 38 deletions(-)
> 
> This breaks the tests:
> 
> ../../../tools/runtest -q -P wine -T ../../.. -M quartz.dll -p quartz_test.exe.so filtergraph && touch filtergraph.ok
> filtergraph.c:566: Tests skipped: L"test.avi": codec not supported; skipping test
> filtergraph.c:589: Test failed: CreateFile failed: err=32
> filtergraph.c:566: Tests skipped: L"test.mpg": codec not supported; skipping test
> filtergraph.c:589: Test failed: CreateFile failed: err=32
> filtergraph.c:57: Test failed: file creation failed, at L"C:\\users\\julliard\\Temp\\test.avi", error 32
> filtergraph.c:64: Test failed: couldn't write resource
> Makefile:280: recipe for target 'filtergraph.ok' failed
> make: *** [filtergraph.ok] Error 4
> 

Thanks for the catch; it was a leak in my implementation of
CBaseFilter::FindPin(). I've sent a patch which should fix this.