[PATCH] msvcrt: Add DECLSPEC_HOTPATCH to functions patched by libtcmalloc

[Zebediah Figura]

On 07/07/18 11:40, Alex Henrie wrote:
> On Sat, Jul 7, 2018 at 1:09 AM Zebediah Figura <z.figura12 at gmail.com> wrote:
>>
>> On 07/07/18 00:16, Alex Henrie wrote:
>>> Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45199
>>> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
>>> ---
>>>  dlls/msvcrt/heap.c | 11 ++++++-----
>>>  1 file changed, 6 insertions(+), 5 deletions(-)
>>>
>>
>> Can't we at least wait for a response on the GCC bug first?
> 
> Even if the GCC bug were fixed immediately, we would still have to add
> DECLSPEC_HOTPATCH as needed until all major distributions adopt the
> next version of GCC. I agree that the situation isn't ideal, but on
> the plus side, even with the 12 functions identified in bug 45199, the
> functions that applications try to patch are still less than 1% of the
> total number of Windows functions.
> 

Propagation may be slow, but I get the impression that we try to avoid
even temporary workarounds if the proper place for the solution is upstream.

Also, since bug 45199 only became really relevant after gcc 8.1, I'm not
sure how concerned we need to be with waiting for "all major distributions".