[PATCH] winedump: Add support for SLTG typelibs.

[Dmitry Timoshkov]

Jacek Caban <jacek at codeweavers.com> wrote:

> On 07/09/2018 08:26 AM, Dmitry Timoshkov wrote:
> > @@ -173,9 +181,6 @@ static int tlb_read_byte(void)
> >  static void print_offset(void)
> >  {
> >      int i;
> > -
> > -    printf("%04x:   ", offset);
> > -
> >      for(i=0; i<indent; i++)
> >          printf("    ");
> >  }
> 
> 
> Why are you dropping printing offset?

It just adds noise. Once you compare old and new output perhaps you will
agree with the change.

> For this and other helper function
> changes, it would be nice to have separated patches.

I considered splitting the whole patch into a series, but the dumper is
a result of pretty old investigation for which I still have full commit
sequence, but the end result is very different from the very first patch,
and unless you would like to see the way of thinking there's really nothing
interesting or fascinating there: once I've found a new .tlb for my collection
I had to adapt the dumper. The changes in the helpers are part of this
investiagtion work, and I don't see a nice way to split them in separate
patches.

-- 
Dmitry.