[PATCH] winedump: Add support for SLTG typelibs.

[Dmitry Timoshkov]

Jacek Caban <jacek at codeweavers.com> wrote:

> >>>  static void print_offset(void)
> >>>  {
> >>>      int i;
> >>> -
> >>> -    printf("%04x:   ", offset);
> >>> -
> >>>      for(i=0; i<indent; i++)
> >>>          printf("    ");
> >>>  }
> >>
> >> Why are you dropping printing offset?
> > It just adds noise. Once you compare old and new output perhaps you will
> > agree with the change.
> 
> It's been a while since I worked with typelibs, but as far as I remember
> a lot of records use offsets and for that having them printed was
> useful. Would it make sense to have a command line option to control if
> they are printed?

The way it looked before my change was
0000:   Header {
0000:       magic1 = 5446534d
0004:       magic2 = 00010002
0008:       posguid = 00000000
000c:       lcid = 00000419
0010:       lcid2 = 00000419
0014:       varflags = 00000051, syskind = SYS_WIN32

That's not how other dumpers' output look like, and printing an offset
before every value is very confusing IMO, unless someone really expects
to see the output similar to the hex viewer, but then again other dumpers
don't do that, and I personally don't find prepending each line with an
offset useful.

After my change it is

Header {
    magic1 = 5446534dh
    magic2 = 00010002h
    posguid = 00000000h
    lcid = 00000419h
    lcid2 = 00000419h
    varflags = 00000051, syskind = SYS_WIN32

-- 
Dmitry.