[PATCH] imaadp32.acm: Avoid ARRAY_SIZE-like macros
Andrew Eikum
aeikum at codeweavers.com
Tue Jul 10 07:32:26 CDT 2018
On Mon, Jul 09, 2018 at 08:44:39PM +0200, Michael Stefaniuc wrote:
> On 07/09/2018 03:08 PM, Andrew Eikum wrote:
> > On Thu, Jul 05, 2018 at 10:07:22PM +0200, Michael Stefaniuc wrote:
> >> @@ -93,11 +90,11 @@ static DWORD ADPCM_GetFormatIndex(const WAVEFORMATEX *wfx)
> >> switch (wfx->wFormatTag)
> >> {
> >> case WAVE_FORMAT_PCM:
> >> - hi = NUM_PCM_FORMATS;
> >> + hi = ARRAY_SIZE(PCM_Formats);
> >> fmts = PCM_Formats;
> >> break;
> >> case WAVE_FORMAT_IMA_ADPCM:
> >> - hi = NUM_ADPCM_FORMATS;
> >> + hi = ARRAY_SIZE(ADPCM_Formats);
> >> fmts = ADPCM_Formats;
> >> break;
> >> default:
> >
> > I'd prefer to keep this as tabs, to stay (more) consistent.
> I have changed it because it is already inconsistent. The "case" uses
> spaces for indentation and that cannot be changed to tabs.
>
It's stupid, but it is consistent. It uses 4-space indents, but swaps
all instances of 8 spaces with a tab character. I'd prefer either
fixing the whole switch-block, or leaving the indentation as it is.
Ditto for the l3codeca and msacm32 patches.
Andrew
More information about the wine-devel
mailing list