[PATCH 3/8] winedump: Stop prepending every line of information with an offset.

Jacek Caban jacek at codeweavers.com
Tue Jul 10 11:31:17 CDT 2018


Signed-off-by: Jacek Caban <jacek at codeweavers.com>


On 07/10/2018 05:41 AM, Dmitry Timoshkov wrote:
> This patch makes typelib output consistent with other dumpers.
>
> Signed-off-by: Dmitry Timoshkov <dmitry at baikal.ru>
> ---
>  tools/winedump/tlb.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/tools/winedump/tlb.c b/tools/winedump/tlb.c
> index e30761540b..0d8f059c03 100644
> --- a/tools/winedump/tlb.c
> +++ b/tools/winedump/tlb.c
> @@ -173,9 +173,6 @@ static int tlb_read_byte(void)
>  static void print_offset(void)
>  {
>      int i;
> -
> -    printf("%04x:   ", offset);
> -
>      for(i=0; i<indent; i++)
>          printf("    ");
>  }

I don't mind the patch, although I'm not sure it's the right thing to
do. Since Dmitry does more work in this area, making the output fit
better to his needs seems a good thing to do.

Jacek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20180710/c78d27de/attachment.html>


More information about the wine-devel mailing list